Skip to content

numpy v1.19.0#195

Merged
isuruf merged 3 commits into
conda-forge:masterfrom
regro-cf-autotick-bot:1.19.0_hf1c5e3
Jul 16, 2020
Merged

numpy v1.19.0#195
isuruf merged 3 commits into
conda-forge:masterfrom
regro-cf-autotick-bot:1.19.0_hf1c5e3

Conversation

@regro-cf-autotick-bot

@regro-cf-autotick-bot regro-cf-autotick-bot commented Jun 20, 2020

Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/25043, please use this URL for debugging

@conda-forge-linter

conda-forge-linter commented Jun 20, 2020

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

h-vetinari commented Jun 21, 2020

Copy link
Copy Markdown
Member

Missing hypothesis as a test dependency:

    import hypothesis
E   ModuleNotFoundError: No module named 'hypothesis'
=========================== short test summary info ============================
ERROR  - ModuleNotFoundError: No module named 'hypothesis'

@jakirkham

jakirkham commented Jun 22, 2020

Copy link
Copy Markdown
Member

Do we know if this is still needed, @isuruf?

numpy-feedstock/recipe/meta.yaml

Lines 31 to 32 in 3f4b2e9

run_constrained:
- libopenblas 0.3.7 # [ppc64le]

@h-vetinari h-vetinari mentioned this pull request Jun 26, 2020
Closed
@h-vetinari

h-vetinari commented Jun 27, 2020

Copy link
Copy Markdown
Member

@jakirkham: Do we know if this is still needed, @isuruf?

Based on the results of trying to remove it in #196, I'd say that it's not needed anymore (i.e. ppc64le builds & tests run through without this on both netlib & openblas)

@mattip

mattip commented Jun 27, 2020

Copy link
Copy Markdown

I would strongly recommend updating openblas to 0.3.10. NumPy released 0.19 with a slightly older commit since 0.3.10 came out too late in the release cycle to update. The latest version fixes some bugs for other architectures and also no longer segfaults with PyPy on linux64

@jakirkham

jakirkham commented Jun 28, 2020

Copy link
Copy Markdown
Member

Yeah I think that is what @h-vetinari is trying in PR ( #196 ). Though we are seeing some failures as noted in comment ( #196 (comment) ).

@h-vetinari

h-vetinari commented Jul 8, 2020

Copy link
Copy Markdown
Member

@conda-forge-admin, please restart ci

@mattip

mattip commented Jul 14, 2020

Copy link
Copy Markdown

Why do the ppc64le runs show numpy1.16? Is that just an artifact or is that really the version?

@mattip

mattip commented Jul 16, 2020

Copy link
Copy Markdown

@isuruf any ideas how to move forward on getting numpy 1.19 onto conda-forge?

@isuruf

isuruf commented Jul 16, 2020

Copy link
Copy Markdown
Member

There's something wrong with the openmp version of openblas. Switching the default to the pthreads version fixed it.

@isuruf isuruf merged commit 3966a4d into conda-forge:master Jul 16, 2020
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.19.0_hf1c5e3 branch July 16, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham Awaiting requested review from jakirkham
@msarahan msarahan Awaiting requested review from msarahan
@ocefpaf ocefpaf Awaiting requested review from ocefpaf
@pelson pelson Awaiting requested review from pelson
@rgommers rgommers Awaiting requested review from rgommers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@regro-cf-autotick-bot @conda-forge-linter @h-vetinari @jakirkham @mattip @isuruf